Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add named capture to non-capturing group mutation #1194

Merged
merged 1 commit into from
Jan 3, 2021
Merged

Add named capture to non-capturing group mutation #1194

merged 1 commit into from
Jan 3, 2021

Conversation

dgollahon
Copy link
Collaborator

@dgollahon dgollahon commented Jan 2, 2021 •
edited
Loading

  • Mutate named capture groups /(?<foo>bar) to passive groups: /(?<foo>bar)/ -> /(?:bar)/.

@dgollahon dgollahon force-pushed the add-named-group-mutations branch 2 times, most recently from f238338 to 037673a Compare January 2, 2021 20:05
@dgollahon dgollahon requested a review from mbj January 2, 2021 23:48
@dgollahon dgollahon force-pushed the add-named-group-mutations branch 2 times, most recently from 1eb798d to cf7c5da Compare January 3, 2021 00:09
@dgollahon
Add named capture to non-capturing group mutation
10d909c 
- Mutate named capture groups to passive groups: `/(?<foo>bar)/` -> `/(?:bar)/`.
@dgollahon dgollahon merged commit 0d4f81e into master Jan 3, 2021
@dgollahon dgollahon deleted the add-named-group-mutations branch January 3, 2021 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbj mbj mbj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dgollahon @mbj